Installing Local Operators Requires Abs or relative notation #1579
Conversation
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
| _, err = m.local.fs.Stat(name) | ||
| // force local operators usage to be either absolute or express a relative path | ||
| // or put another way, a name can NOT be mistaken to be the name of a local folder | ||
| if filepath.Base(name) != name && err == nil { |
There was a problem hiding this comment.
Please update the comment to this method and the help for the cmd/install.go command (it's partially invalid now)
There was a problem hiding this comment.
This comment is still valid. The human operator must provide an absolute path or express a rel path (and not just the folder name)
There was a problem hiding this comment.
I meant the fact that the relative path must begin with ./ e.g. ./kafka and not just kafka as was possible previously. In a way, this change might be even breaking for someone.
There was a problem hiding this comment.
It is not clear what you are asking for...
This could be considered a breaking change... but it is a breaking change for an operator dev... What is the likelihood that a regular user relies not on our repo but on a local file folder... and requiring a rel or abs path is an issue?
what we do have is a number of people and an issue that explicit states that the opposite is true... people are frustrated that an operator with the same name of an existing sub folder fails.
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
added
release/breaking-change
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Please read #1557 for full context. There has been confusion around specifying an operator name which is the same name as a folder in the CWD. The issue makes a lot of sense. There were a number of suggestions including sending details to STDOUT.
I'm not a fan of noisy CLIs... the information is there if you increase verbosity (
-v=2).The biggest issue is that if there is a folder with the same name as an operator, it is assumed to be what the user wants... all that was previously necessary is that
fs.Stat(name)passes.. If this condition exists, there is no attempt to go to a repo etc.The change makes necessary to specify a local operator with more than just a name... if it is in the CWD than
install ./fooorinstall ./foo.tgzis necessary. It requires that more than the base name (go parlance) be supplied. It also accepts an absolute path. 2 things are now required... 1) it isn't just a filename and 2) the file or folder exists.Signed-off-by: Ken Sipe kensipe@gmail.com
Fixes #1557