Script File Linting #1584
Merged
Script File Linting #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
ANeumann82
approved these changes
Jul 10, 2020
| @@ -31,7 +31,7 @@ do | |||
|
|
|||
| # Extract fields from header | |||
| KEP_NUMBER=$(echo "$KEP_HEADER" | sed -n -E 's/kep-number: ([0-9]+)/\1/p') | |||
| KEP_NUMBER=$(echo "$KEP_NUMBER" | sed 's/^0*//') # Strip leading zeros, or we interpret in octal | |||
| KEP_NUMBER="$((10#$KEP_NUMBER))" # Strip leading zeros, or we interpret in octal | |||
There was a problem hiding this comment.
Is there a way we can keep this as it was? The echo and sed makes it pretty clear what's happening, but this new way seems kind of exotic to me?
Not a blocker though, the comment says what it does, so i guess it's ok
There was a problem hiding this comment.
@ANeumann82 I actually think what you had was easier to read or understand as well :( shellcheck failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From project root the following is clean now
for f in hack/*.sh; do shellcheck $f; doneSigned-off-by: Ken Sipe kensipe@gmail.com