Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Readme #1587

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Development Readme #1587

merged 3 commits into from
Jul 13, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Jul 10, 2020

Adding a development.md with a link from the project readme.
This is consistent with kube community approach. Example: https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#building-kubernetes-on-a-local-osshell-environment

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

development.md Outdated Show resolved Hide resolved
development.md Show resolved Hide resolved
development.md Outdated Show resolved Hide resolved
development.md Outdated Show resolved Hide resolved
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, apart from Aleans comments


When running locally we assume that you will not be using a CertManager thus initialization is with `--unsafe-self-signed-webhook-ca`.

### Running KUDO locally in Cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also mention kind and kind load docker-image <image>

development.md Outdated Show resolved Hide resolved
development.md Show resolved Hide resolved
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe kensipe merged commit 3e1c717 into main Jul 13, 2020
@kensipe kensipe deleted the ken/dev-readme branch July 13, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants