Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and single test execution for kuttl tests #1595

Merged
merged 17 commits into from
Jul 15, 2020

Conversation

ANeumann82
Copy link
Member

What this PR does / why we need it:

  • Allows running a single integration/e2e/upgrade test with make TEST=plan-trigger e2e-test
  • Moved kuttle config files into test folder
  • Added artifacts directory so the kind-log folders don't clutter the root directory
  • Updated README in tests to reflect the changes

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
…he test folder now

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A naming nit but otherwise LGTM!

test/README.md Outdated Show resolved Hide resolved
test/README.md Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
@zen-dog
Copy link
Contributor

zen-dog commented Jul 14, 2020

488f6f

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
@@ -41,8 +37,7 @@ if docker build -f test/Dockerfile -t kudo-test .; then
if docker run -e INTEGRATION_OUTPUT_JUNIT --net=host -it --rm -m 4g \
-v /var/run/docker.sock:/var/run/docker.sock \
-v "$(pwd)"/reports:/go/src/github.com/kudobuilder/kudo/reports \
-v "$(pwd)"/kind-logs:/tmp/kudo-e2e-test \
kudo-test bash -c "make $TARGET; ret=\$?; chmod a+r -R /tmp/kudo-e2e-test; exit \$ret"
kudo-test bash -c "make $TARGET; ret=\$?; chmod a+r -R /go/src/github.com/kudobuilder/kudo/reports; exit \$ret"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏
Good to know! The reason for the /tmp/kudo-e2e-test was the requirement for absolute paths and not knowing where the reports would be written by default.

@ANeumann82 ANeumann82 merged commit 645c9b9 into main Jul 15, 2020
@ANeumann82 ANeumann82 deleted the an/cleanup-testing branch July 15, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants