Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back from apiext v1 to v1beta1 #1597

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Switch back from apiext v1 to v1beta1 #1597

merged 2 commits into from
Jul 16, 2020

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Jul 14, 2020

With this change we support even k8s < 1.16 but at the same time we also support all following k8s versions. We should do this change when v1beta1 is not available and then talk about the support matrix.

Fixes #1577

Signed-off-by: Alena Varkockova varkockova.a@gmail.com

Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one failing Test: TestPrereq_Fail_PreValidate_Webhook_WrongCertificateVersion.

Apart from that lgtm. We still need to make a decision when to switch over to v1 and drop support for Kubernetes < 1.16

Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
@alenkacz alenkacz merged commit 352f47c into main Jul 16, 2020
@alenkacz alenkacz deleted the av/v1-apiext branch July 16, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apiextensions.k8s.io/v1 not available until Kubernetes 1.16.0.
2 participants