Allow custom output directory for diagnostics collection #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
zen-dog
reviewed
Jul 15, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
|
How does this differ from #1599? |
It doesn't. Alena and I implemented this independently. She was trying out the diagnostic feature, I was trying to integrate it with KUDO Cassandra and we both noticed that it needs to be done |
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
|
Can you and @alenkacz reconcile which one should be closed? |
|
I've closed Alenas PR (after reconciling with her), I'm going to add her as Co-Author on this one when it's merged. |
nfnt
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Allow
kudo diagnostics collect --outputDir instance1so we can collect multiple diagnostics in the same directory