Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log anything when validating dummy task #1604

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Don't log anything when validating dummy task #1604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/kudoctl/packages/convert/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package convert
import (
"errors"
"fmt"
"log"
"strings"

corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -125,7 +124,7 @@ func validateTask(t v1beta1.Task, templates map[string]string) []string {
resources = append(resources, t.Spec.ParameterFile)
}
case task.DummyTaskKind:
log.Printf("no validation for task kind %s implemented", t.Kind)
// Nothing to validate for Dummy Task
default:
errs = append(errs, fmt.Sprintf("unknown task kind %s", t.Kind))
}
Expand Down