Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for goreleaser based on deprecation #1606

Merged
merged 1 commit into from
Jul 17, 2020
Merged

update for goreleaser based on deprecation #1606

merged 1 commit into from
Jul 17, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Jul 15, 2020

https://goreleaser.com/deprecations/#brewsgithub

to test: goreleaser check

Signed-off-by: Ken Sipe kensipe@gmail.com

https://goreleaser.com/deprecations/#brewsgithub

to test: `goreleaser check`

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@alenkacz
Copy link
Contributor

should we note somewhere which version of goreleaser we currently support? Is there a way to somehow "fix" it like if we would be using go.mod or other dependency resolution thing?

Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @alenkacz, it would be great to add the used version of goreleaser to RELEASE.md.

@kensipe
Copy link
Member Author

kensipe commented Jul 17, 2020

that's a great point @alenkacz . My initial reaction was resistant because it is generally the latest release of goreleaser and it seems like a burden to update docs for every change... however I have a strong preference to have a repeatable, reproducible and traceable build chain. Unfortunately goreleaser, while a go application, is a binary and isn't managed in the build chain via tools.go etc. It seems that if we had the release as part of a CI build (which we should drive to) that the version will be either on the build image or be part of the build infrastructure pipeline scripts.

I don't see it as blocking this PR. I'll write an issue regarding this which can prioritize.

Thanks for thinking big picture and driving dev / release maturity in the process!

@kensipe kensipe merged commit c8bd36b into main Jul 17, 2020
@kensipe kensipe deleted the ken/goreleaser branch July 17, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants