Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-cluster resolver to properly resolve x-ns OV/I resources #1609

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

zen-dog
Copy link
Contributor

@zen-dog zen-dog commented Jul 16, 2020

bu using the top-level OperatorVersion namespace instead of that of the Instance when resolving the dependencies.

Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com

bu using the top-level `OperatorVersion` namespace instead of that of the `Instance` when resolving the dependencies.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Copy link
Member

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zen-dog ! 🙌

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zmalik zmalik merged commit f2142a9 into main Jul 17, 2020
@zmalik zmalik deleted the ad/x-ns-incluster-resolver branch July 17, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants