Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trigger non-existing plan #1616

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Do not trigger non-existing plan #1616

merged 1 commit into from
Jul 22, 2020

Conversation

alenkacz
Copy link
Contributor

Signed-off-by: Alena Varkockova varkockova.a@gmail.com

What this PR does / why we need it:
Fixes #1612

@alenkacz
Do not trigger non-existing plan
8242ac9 
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
ANeumann82
ANeumann82 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, interesting that we didn't check that before :) Good catch

nfnt
nfnt approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alenkacz alenkacz merged commit 9666e01 into main Jul 22, 2020
@alenkacz alenkacz deleted the av/reject-nonexisting branch July 22, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@nfnt nfnt nfnt approved these changes

@gerred gerred Awaiting requested review from gerred

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kudo plan trigger does not fail on non-existing plan
3 participants
@alenkacz @ANeumann82 @nfnt