Add e2e test for apply-delete-apply bug #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
force-pushed
the
av/delete-apply-delete-test
branch
2 times, most recently
from
d035c1f
to
28421a0
Compare
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
force-pushed
the
av/delete-apply-delete-test
branch
from
28421a0
to
66d369a
Compare
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
changed the title
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
changed the title
ANeumann82
approved these changes
Jul 31, 2020
nfnt
approved these changes
Jul 31, 2020
|
@nfnt oh right, there could be multiple resources in an assert, correct? Yeah, let's change that |
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This covers regression in #1596
It had to be e2e because in integration, the deletion actually never happens because the GC controller is not running.