Add --output parameter to plan status to allow json/yaml output #1634
Conversation
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
pkg/kudoctl/cmd/plan/plan_status.go
Outdated
|
|
||
| var o []byte | ||
| if strings.ToLower(options.Output) == "yaml" { | ||
| o, err = yaml.Marshal(instance.Status) |
There was a problem hiding this comment.
shouldn't we aim for something more user friendly then just serialized CRD status? 🤔
There was a problem hiding this comment.
That's a good question. I'm not sure what would be more user friendly though...
There was a problem hiding this comment.
the rest of k8s simply outputs the resource yaml - why would we convert? I'd rather leave it as is
There was a problem hiding this comment.
I would like to see a test here :) at least I can see how the output actually look like
@alenkacz Added tests :) And ended up refactoring this quite a bit. The output for yaml/json plan status is still the instance.status though.
It might be a good idea to use a separate data structure so we don't break clients if we end up changing the instance.status....
Add json output for kudo init Add tests for plan status with json/yaml output Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
…pe is given Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Add
--outputparameter tokudo plan statusto allow json/yaml output instead of human readable formatFixes #