KUDO init --wait checks statefulset instead of pod #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
requested review from
gerred,
kensipe,
nfnt and
zen-dog
as code owners
|
I'll investigate the failures tomorrow |
alenkacz
changed the title
zen-dog
reviewed
Aug 7, 2020
pkg/kudoctl/kudoinit/setup/wait.go
Outdated
|
|
||
| s, err := managerContainerStatus(pod) | ||
| if err != nil { | ||
| pod, err := getFirstReadyPod(client, namespace, selector) |
There was a problem hiding this comment.
Now that I'm looking at it again: why do we check the individual manager pods? It is a StatefulSet so why not simply check that with the healthutil?
There was a problem hiding this comment.
I thought statefulset does not have enough information about readiness but it does so ... thank you :) you're right
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
changed the title
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
force-pushed
the
av/health-ready-pod
branch
from
19644e6
to
fdbb20a
Compare
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
changed the title
ANeumann82
approved these changes
Aug 20, 2020
nfnt
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alena Varkockova varkockova.a@gmail.com
What this PR does / why we need it:
Not only
--wait, also the health module should read thereadyproperty, notphase == running.See https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ for more context.