stylecheck added to linting and issues resolved #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
alenkacz,
gerred,
nfnt and
zen-dog
as code owners
zen-dog
approved these changes
Aug 10, 2020
| @@ -169,7 +169,7 @@ func (initCmd *initCmd) run() error { | |||
| "IfNotPresent": | |||
| opts.ImagePullPolicy = initCmd.imagePullPolicy | |||
| default: | |||
| return fmt.Errorf("Unknown image pull policy %s, must be one of 'Always', 'IfNotPresent' or 'Never'", initCmd.imagePullPolicy) | |||
| return fmt.Errorf("unknown image pull policy %s, must be one of 'Always', 'IfNotPresent' or 'Never'", initCmd.imagePullPolicy) | |||
There was a problem hiding this comment.
I'm not sure about the small case: this string is afaik user-facing (and is not wrapped) - shouldn't it start with a capital letter?
| @@ -20,7 +20,7 @@ func ForOperator(fs afero.Fs, pathDefault string, overwrite bool, operatorDefaul | |||
|
|
|||
| nameValid := func(input string) error { | |||
| if len(input) < 3 { | |||
| return errors.New("Operator name must have more than 3 characters") | |||
| return errors.New("operator name must have more than 3 characters") | |||
There was a problem hiding this comment.
Same for all these errors.
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
|
resolved merge conflict... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ken Sipe kensipe@gmail.com