Refactor/Cleanup for output parameter #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use type for output Add separate Options for plan status Add tests to validate invalid output parameter Cleanup tests to use separate t.Run executions Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
alenkacz
approved these changes
Aug 19, 2020
pkg/kudoctl/cmd/init.go
Outdated
| @@ -110,7 +110,7 @@ func newInitCmd(fs afero.Fs, out io.Writer, errOut io.Writer, client *kube.Clien | |||
| f.StringVarP(&i.image, "kudo-image", "i", "", "Override KUDO controller image and/or version") | |||
| f.StringVarP(&i.imagePullPolicy, "kudo-image-pull-policy", "", "Always", "Override KUDO controller image pull policy") | |||
| f.StringVarP(&i.version, "version", "", "", "Override KUDO controller version of the KUDO image") | |||
| f.StringVarP(&i.output, "output", "o", "", "Output format") | |||
| f.StringVarP((*string)(&i.output), "output", "o", "", "Output format") | |||
There was a problem hiding this comment.
could we do rather something like i.output.AsString? 🤔 to not hardcode here expectations about the type alias...
There was a problem hiding this comment.
I can do:
f.StringVarP(i.output.AsStringPtr, "output", "o", "", "Output format")
zen-dog
approved these changes
Aug 19, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use type for output
Add separate Options for plan status
Add tests to validate invalid output parameter
Cleanup tests to use separate t.Run executions
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Started to add
--output yamltopackage verifyandpackage createand ended up refactoring cleaning up a couple things - Decided to make it a separate PR for easier Review