Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "--output yaml" to kudo package verify #1646

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Add "--output yaml" to kudo package verify #1646

merged 2 commits into from
Aug 21, 2020

Conversation

ANeumann82
Copy link
Member

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

What this PR does / why we need it:

Add --output parameter to package verify and package create

This allows users to easily parse the output of both commands

Fixes #1644

@ANeumann82
Add "--output yaml" to kudo package verify
220f37d 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
zen-dog
zen-dog approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that kudo package create -o yaml can be misinterpreted as package output format. But otherwise, lgtm

pkg/kudoctl/cmd/package_create.go Outdated Show resolved Hide resolved
@ANeumann82
Adjusted help text for new parameter
815da9f 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
@ANeumann82 ANeumann82 merged commit c063a82 into main Aug 21, 2020
@ANeumann82 ANeumann82 deleted the an/add-output-to-package-verify branch August 21, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog zen-dog approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@nfnt nfnt Awaiting requested review from nfnt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --output yaml for kudo package verify and kudo package create
2 participants
@ANeumann82 @zen-dog