Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate execution of Go integration tests and kuttl integration tests #1647

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

ANeumann82
Copy link
Member

@ANeumann82 ANeumann82 commented Aug 19, 2020

Use separate targets in Makefile so running a single suite is easier

  • Separate Go integration tests and kuttl integration tests
  • Test for Goland variable in running go integration tests
  • Add more documentation to make help

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

What this PR does / why we need it:

…s in Makefile so running a single suite is easier

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Should we update our CircleCI configuration as well, so that it runs these tests in parallel? Or is this mostly meant for dev running tests locally?

@ANeumann82
Copy link
Member Author

LGTM!
Should we update our CircleCI configuration as well, so that it runs these tests in parallel? Or is this mostly meant for dev running tests locally?

It was mostly meant for devs to run tests locally. I don't think we need to split it in the CI, at the moment either the e2e or the operator tests take longer than the combined integration tests, so we don't win anything.

@ANeumann82 ANeumann82 merged commit 0a55697 into main Aug 21, 2020
@ANeumann82 ANeumann82 deleted the an/separate-integration-tests branch August 21, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants