Abort plan with FATAL_ERROR if an unknown custom resource deployed #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be deployed. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
…step Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
alenkacz
requested changes
Aug 20, 2020
Do you mean wait for CRDs to appear in Discovery in the health check? Because I think that's the only place where we should wait for a CRD to appear, right? |
|
@ANeumann82 yes, it's basically #1341 |
alenkacz
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently KUDO throws a normal error which means retry if a task tries to deploy a custom resource which is unknown to the k8s cluster.
This PR changes this to a FATAL_ERROR. CRDs should be installed correctly in a previous task before the next one is started.
To install CRDs correctly within an operator, CRDs now have a health checks so KUDO can wait until the CRD is correctly installed.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
Fixes #1523, #1341