Check if the target namespace is terminating and abort installation #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… installation Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
nfnt
approved these changes
Aug 20, 2020
zen-dog
approved these changes
Aug 20, 2020
|
|
||
| // If either custom or default ns is terminating, we can't install | ||
| if err == nil { | ||
| if ns.Status.Phase == v1.NamespaceTerminating { |
There was a problem hiding this comment.
I'm not sure but wdyt about putting this check in the health.go? E.g. a healthy namespace has the NamespaceActive phase?
There was a problem hiding this comment.
Phase can currently only be Active or Terminating, so we don't need a health check for NS (at the moment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
Fixes #1627