Expanded upgrade test #1652
Merged
Expanded upgrade test #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
ANeumann82
commented
Aug 21, 2020
| @@ -80,7 +80,7 @@ lint: ## Run golangci-lint | |||
| ifneq (${GOLANGCI_LINT_VER}, "$(shell golangci-lint --version 2>/dev/null | cut -b 27-32)") | |||
| ./hack/install-golangcilint.sh | |||
| endif | |||
| golangci-lint --timeout 3m run | |||
| golangci-lint --timeout 3m run --allow-parallel-runners | |||
There was a problem hiding this comment.
I had to add this as IntelliJ kept failing on the git commithooks...
nfnt
requested changes
Aug 21, 2020
There was a problem hiding this comment.
The kubectl-kudo entry in .gitignore is a bit suspicious. Looks like the binary is supposed to be copied into the test folder, but there isn't any code to do that. Furthermore, existing tests call kubectl kudo for a KUDO binary that's in $PATH, let's keep using this approach here as well.
nfnt
approved these changes
Aug 21, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
This PR extends the upgrade test. Until now, we would:
With this PR we:
kudo init --upgrade --dry-run --output yaml | kubectl delete -f -