Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return health status for V1 CRDs #1675

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Return health status for V1 CRDs #1675

merged 2 commits into from
Sep 7, 2020

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Sep 4, 2020

What this PR does / why we need it:
The v1 CRD API is available since Kubernetes 1.16 and should be supported in addition to the v1beta1 API that's deprecated beginning with Kubernetes 1.19.

The v1 CRD API is available since Kubernetes 1.16 and should be supported in addition to the v1beta1 API that's deprecated beginning with Kubernetes 1.19.

Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt nfnt self-assigned this Sep 4, 2020
@nfnt nfnt requested a review from ANeumann82 September 4, 2020 11:21
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I kind of wish the alias names were shorter... perhaps apiv1 for apiextv1 but not a big deal. nice addition!

Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt
Copy link
Member Author

nfnt commented Sep 7, 2020

I like apiextv1, apiextv1beta1. Think I saw this alias used in other projects as well.

Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nfnt nfnt merged commit 8b8a68a into main Sep 7, 2020
@nfnt nfnt deleted the nfnt/v1-crd-health branch September 7, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants