Bump direct dependencies to their latest releases #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Kubernetes client API to 0.19.1. Furthermore, 'controller-tools' has been updated to a version that generates V1 CRDs. Signed-off-by: Jan Schlicht <jan@d2iq.com>
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
added 3 commits
September 16, 2020 11:16
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
I don't think we can drop support for the v1beta1 today. See for example this recent commit. |
|
Yes, switching to V1 CRDs would drop support for Kubernetes < 1.16 which would be in line with the proposed API version policy. |
|
Updating |
added 4 commits
September 17, 2020 09:16
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Not all tooling is able to handle v1 CRDs yet, let's keep generating v1beta1 CRDs. Signed-off-by: Jan Schlicht <jan@d2iq.com>
|
I'll keep the CRDs at |
added 4 commits
October 2, 2020 12:13
This reverts commit faece87. Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
ANeumann82
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes the Kubernetes client API to 0.19.2.
Furthermore,
controller-toolshas been updated. This version creates V1 CRDs by default, but its configuration has been changed to still create v1beta1 CRDs, as some clusters might have components that don't support V1 CRDs yet.Go 1.15 is used for builds.