Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Mod Tidy #1686

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Go Mod Tidy #1686

merged 1 commit into from
Sep 18, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Sep 16, 2020

Go.Sum was dirty with older references... we should create a CI check for this...

Signed-off-by: Ken Sipe kensipe@gmail.com

@kensipe
Go Mod Tidy
54f9c07 
Signed-off-by: Ken Sipe <kensipe@gmail.com>
nfnt
nfnt approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
This should be discovered implicitly with make test as the is running the tests with mod=readonly flag. Obviously this doesn't cover all packages, so a different check makes sense to have.

@nfnt nfnt merged commit 5f4a85f into main Sep 18, 2020
@nfnt nfnt deleted the ken/go-mod-tidy branch September 18, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfnt nfnt nfnt approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kensipe @nfnt