Calculate health for services #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A service is considered healthy if its cluster IP is accessible. Furthermore, if the service is load-balanced, then balancer needs to have an ingress defined. Signed-off-by: Jan Schlicht <jan@d2iq.com>
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
Signed-off-by: Jan Schlicht <jan@d2iq.com>
nfnt
force-pushed
the
nfnt/service-health
branch
from
5686276
to
e000d25
Compare
zen-dog
approved these changes
Oct 7, 2020
Signed-off-by: Jan Schlicht <jan@d2iq.com> Co-authored-by: Aleksey Dukhovniy <adukhovniy@mesosphere.io>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
alenkacz
approved these changes
Oct 8, 2020
|
@alenkacz Great suggestion, I'll add unit tests for |
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A service is considered healthy if its cluster IP is accessible. Furthermore, if the service is load-balanced, then balancer needs to have an ingress defined.
Fixes #1699