Package resolvers now only returns resolved resources #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen-dog
requested review from
alenkacz,
gerred,
kensipe and
nfnt
as code owners
ANeumann82
approved these changes
Oct 20, 2020
nfnt
reviewed
Oct 20, 2020
nfnt
approved these changes
Oct 20, 2020
Summary:
Package resolver interface used to return `package.Package` containing the underlying package files and the converted resources:
```
type Package struct {
// transformed server view
Resources *Resources
// working with local package files
Files *Files
}
```
The original assumption was that the files are always present. However, in some cases e.g. `InClusterResolver` all the resources are already installed in the cluster and there are no files which lead to some hacky workaround. Turns out, that files are not needed as most callers needed the resolved resources anyway.
This refactoring removes this entanglement and allows for better integration of already installed operators e.g. one could list parameters of the installed zookeeper operator with: `kudo package list parameters zookeeper --in-cluster` (not yet implemented).
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
…anymore Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
force-pushed
the
ad/entangle-resolver
branch
from
6193606
to
7a533e0
Compare
alenkacz
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Package resolver interface used to return
package.Packagecontaining the underlying package files and the converted resources:The original assumption was that the files are always present. However, in some cases e.g.
InClusterResolverall the resources are already installed in the cluster and there are no files that lead to some hacky workaround. Turns out, that files are not needed as most callers needed the resolved resources anyway.This refactoring removes this entanglement and allows for better integration of already installed operators e.g. one could list parameters of the installed zookeeper operator with:
kudo package list parameters zookeeper --in-cluster(not yet implemented).Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com