Move KUDO to v1 CRDs #1725
Merged
Move KUDO to v1 CRDs #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
requested review from
gerred,
jbarrick-mesosphere,
kensipe,
nfnt and
zen-dog
as code owners
alenkacz
force-pushed
the
av/v1crd
branch
3 times, most recently
from
0ff713d
to
7c357c2
Compare
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
kensipe
approved these changes
Nov 10, 2020
cmd/manager/main.go
Outdated
| @@ -25,7 +25,7 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| apiextenstionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1" | |||
| apiextenstionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" | |||
There was a problem hiding this comment.
not an issue... but we have this defined in other places
extv1apiext1(which is my preference)
we should standard it. (not necessarily part of this PR)
There was a problem hiding this comment.
went for apiext1 thanks
| @@ -7,6 +7,8 @@ import ( | |||
| "fmt" | |||
| "log" | |||
|
|
|||
| apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" | |||
| @@ -1,5 +1,3 @@ | |||
| // +build integration | |||
|
|
|||
| package cmd | |||
There was a problem hiding this comment.
is there a reason to remove +build integration tag? Should the class be renamed to reflect it?
| @@ -63,7 +63,8 @@ func paramDefaults(pf *packages.Files) verifier.Result { | |||
| res := verifier.NewResult() | |||
| for _, p := range pf.Params.Parameters { | |||
| if p.HasDefault() { | |||
| if err := p.ValidateDefault(); err != nil { | |||
| if err := p. | |||
There was a problem hiding this comment.
ugh... do we really need to do this?
There was a problem hiding this comment.
no, I don't know what happened here :/
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This moves KUDO to v1 CRDs only (meaning we support only k8s 1.16+).
Fixes #1723