Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint bump 1.32.2 #1731

Merged
merged 3 commits into from
Nov 4, 2020
Merged

lint bump 1.32.2 #1731

merged 3 commits into from
Nov 4, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Nov 3, 2020

  • Updated golangci-lint to version 1.32.2
  • Reorganized linters to be alphabetical (making it easy to discover which are included or not)
  • ignoring gosec for tests

Fixes #

@kensipe
bump golangci linter to 1.32.2
5572172 
Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe
reorg linters to be alphabetical and ignoring gosec for test files
a495009 
Signed-off-by: Ken Sipe <kensipe@gmail.com>
nfnt
nfnt approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kensipe
Adding a number of additional linters gofmt required code updates to …
ae336fb 
…resolve (#1732)

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe kensipe merged commit e568609 into main Nov 4, 2020
@kensipe kensipe deleted the ken/lint-bump-1.32.2 branch November 4, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfnt nfnt nfnt approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kensipe @nfnt