Do not trigger an update when a parameter is added by an OV upgrade. #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asekretenko
force-pushed
the
kudo_1776_fix
branch
from
a2db2ec
to
36ea5f2
Compare
asekretenko
changed the title
Currently, an operator upgrade that brings in a new required parameter without a default, is impossible if the operator defines both "update" and "upgrade" plans. An upgrade without setting this parameter fails (which is a correct behaviour); however, an attempt to upgrade while setting the previously nonexistent parameter also fails due to both plans being triggered, regardless of the fact that no existing parameter is changed. This test verifies that an upgrade of such an operator is possible together with setting a value for the new required parameter, and that the plan chosen is "upgrade" and not "update". Signed-off-by: Andrei Sekretenko <asekretenko@d2iq.com>
Now, parameters added by a new operator version (for example, when a new OV brings in a new required parameter with no default, so that it is necessary to set a value together with upgrade) no longer trigger an update plan. This fixes kudobuilder#1776 Signed-off-by: Andrei Sekretenko <asekretenko@d2iq.com>
asekretenko
force-pushed
the
kudo_1776_fix
branch
from
36ea5f2
to
fd157fc
Compare
asekretenko
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
ANeumann82
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, parameters added by a new operator version (for example, when
a new OV brings in a new required parameter with no default, so that
it is necessary to set a value together with upgrade) no longer trigger
an update plan.
Fixes #1776