Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a user story #183

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Adding a user story #183

merged 1 commit into from
Apr 17, 2019

Conversation

djannot
Copy link
Contributor

@djannot djannot commented Apr 12, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/component generator
/component kudoctl
/component operator
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind feature
/kind enhancement
/kind infrastructure
/kind kep

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@guenter
Copy link
Member

guenter commented Apr 12, 2019

As I think through how we would implement this I think it's a new use case for triggers that's not covered by the other stories so I'm +1 for this.

@@ -104,6 +105,10 @@ As a Kafka administrator I want to change the number of Kafka brokers in a clust

As a Kafka administrator I want to deploy configuration changes to the cluster with minimal disruption to clients so I can make changes without creating a new cluster.

#### Handle Failures

When a Pod corresponding to Kafka Broker is restarted (because of a Kubelet failure, for example), I want a task to run to verify the health of the Broker and to perform a maintenance if needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot missing at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in many ways of a Plan as the answer to how failures should be handled. I can also think of more custom logic up to the App Developer, even similar declarative in away on how to define what failure is, what it represents and how it is been dealt with. This could be an entire new component or extension to what is currently provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'm ok with how this is written in the sense of what @guenter said - a user mechanism of watching for application level events and triggering a plan does not exist today.

As a Kafka administrator I want to have easy access to Kafka's JMX metrics so I can easily debug problems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great. We should also overall think more of how to incorporate in house monitoring and metrics.

@gerred gerred merged commit ade9870 into kudobuilder:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants