Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a coding style guide #191

Merged
merged 5 commits into from
Apr 15, 2019
Merged

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Apr 15, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Starts a coding style guide

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
It is expected that this is a living document. It doesn't make sense to capture all possible cases upfront. however, as we get and give PR feedback, cases needing clarification should be added here.

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@fabianbaier fabianbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

STYLEGUIDE.md Outdated Show resolved Hide resolved
STYLEGUIDE.md Outdated Show resolved Hide resolved
STYLEGUIDE.md Outdated Show resolved Hide resolved
STYLEGUIDE.md Outdated Show resolved Hide resolved
STYLEGUIDE.md Outdated Show resolved Hide resolved
STYLEGUIDE.md Outdated Show resolved Hide resolved
@kensipe kensipe merged commit ac4c089 into kudobuilder:master Apr 15, 2019
@kensipe kensipe deleted the ken/style-guide branch April 15, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants