Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline JSON struct tags #196

Merged
merged 3 commits into from Apr 18, 2019
Merged

Fix inline JSON struct tags #196

merged 3 commits into from Apr 18, 2019

Conversation

gerred
Copy link
Member

@gerred gerred commented Apr 18, 2019 •
edited

These were originally reported by staticcheck, but staticcheck master has been fixed to account for openapi-gen mis-using the json struct tags.

@gerred gerred requested review from kensipe and runyontr April 18, 2019 00:17
@gerred gerred requested a review from fabianbaier April 18, 2019 00:21
@gerred
Copy link
Member Author

gerred commented Apr 18, 2019

thanks @dominikh

@gerred gerred changed the title Fix inline JSON struct tags. These were originally reported by staticcheck, but staticcheck master has been fixed. Fix inline JSON struct tags Apr 18, 2019
@gerred gerred changed the title Fix inline JSON struct tags [WIP] [DONTMERGE] Fix inline JSON struct tags Apr 18, 2019
@gerred gerred changed the title [WIP] [DONTMERGE] Fix inline JSON struct tags Fix inline JSON struct tags Apr 18, 2019
kensipe
kensipe approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... it was correct coming from kubebuilder... good find! lgtm

fabianbaier
fabianbaier approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@fabianbaier fabianbaier left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

this should also fix #194

@gerred
Copy link
Member Author

gerred commented Apr 18, 2019

closes #194

@gerred gerred merged commit a843a20 into master Apr 18, 2019
@gerred gerred deleted the fix-api-gen branch April 18, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@fabianbaier fabianbaier fabianbaier approved these changes

@runyontr runyontr Awaiting requested review from runyontr

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gerred @kensipe @fabianbaier