Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparion between tools #22

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Comparion between tools #22

merged 3 commits into from
Apr 18, 2019

Conversation

runyontr
Copy link
Member

@runyontr runyontr commented Dec 3, 2018

@gerred @joerg84

This is something I'm going to keep working on over the next few days, but wanted to have this here to comment on.

Copy link
Contributor

@joerg84 joerg84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@runyontr Is it ok to just push my comments as PR?

docs/Comparison.md Outdated Show resolved Hide resolved
docs/Comparison.md Show resolved Hide resolved
docs/Comparison.md Outdated Show resolved Hide resolved
@runyontr
Copy link
Member Author

runyontr commented Dec 3, 2018

@joerg84 Please push any changes you want, I just wanted to start the conversation.

@fabianbaier
Copy link
Member

Can we close this?

Copy link
Contributor

@joerg84 joerg84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except typos as the first iteration. But needs some more iterations :-)

…atting. fixed a number a number of misspellings
@kensipe
Copy link
Member

kensipe commented Apr 18, 2019

I pushed a cleaned up version of this document.... we should decide if we want this or not.

@gerred
Copy link
Member

gerred commented Apr 18, 2019

lgtm. I think this is using a very old circle.yaml so no risk about that check failing.

@gerred gerred self-requested a review April 18, 2019 12:55
@gerred gerred merged commit 44e1df3 into master Apr 18, 2019
@gerred gerred deleted the comparion-between-tools branch April 18, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants