Adding goreleaser #236
Adding goreleaser #236
Conversation
Including circleci Adding docs for release process
RELEASE.md
Outdated
|
|
||
| ## Release Process | ||
|
|
||
| The official binaries for Kudo is created using [goreleaser](https://goreleaser.com/) for the release process through the cicleci release job. The [.goreleaser.yml](.goreleaser.yml) defines the binaries which are supported for each release. |
There was a problem hiding this comment.
I did mean "supported"... the supported and defined platforms will be created
| - restore_cache: | ||
| keys: | ||
| - go-mod-v1-{{ checksum "go.sum" }} | ||
| - run: curl -sL https://git.io/goreleaser | bash |
There was a problem hiding this comment.
shouldn't we have this defined in makefile so one can run even locally?
There was a problem hiding this comment.
also in the future it would be nice to run tests before release. We cannot do that now though...
There was a problem hiding this comment.
shouldn't we have this defined in makefile so one can run even locally?
I generally like this idea. In this case, we'd add it to tools.go as well so we're pinned to a version of goreleaser - not sure if that fits in with how goreleaser is versioned though.
There was a problem hiding this comment.
Overall fine with keeping it how it is now and doing that in a separate PR too.
| - restore_cache: | ||
| keys: | ||
| - go-mod-v1-{{ checksum "go.sum" }} | ||
| - run: curl -sL https://git.io/goreleaser | bash |
There was a problem hiding this comment.
Overall fine with keeping it how it is now and doing that in a separate PR too.
|
lgtm |
What type of PR is this?
/kind infrastructure
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Including circleci
Adding docs for release process
Does this PR introduce a user-facing change?: