Remove vars, pass params explicitly #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
commented
Jun 10, 2019
| ) | ||
|
|
||
| func TestInstallCmd(t *testing.T) { |
There was a problem hiding this comment.
these tests were moved to parameters test in the other install_test file
gerred
requested changes
Jun 10, 2019
pkg/kudoctl/cmd/install/install.go
Outdated
| KubeConfigPath string | ||
| } | ||
|
|
||
| func NewOptions() *Options { |
There was a problem hiding this comment.
Since this is just creating a struct, I'd just have this be a var..
var *Options DefaultOptions = &Options{
...
}That way it can be inlined by the compiler.
There was a problem hiding this comment.
Having this as a function is useful when you have other functions you need to call in order to set this struct up.
gerred
approved these changes
Jun 10, 2019
fabianbaier
approved these changes
Jun 10, 2019
pkg/kudoctl/cmd/install.go
Outdated
| installCmd.Flags().BoolVar(&options.AutoApprove, "auto-approve", false, "Skip interactive approval when existing version found. (default \"false\")") | ||
| installCmd.Flags().StringVar(&options.KubeConfigPath, "kubeconfig", "", "The file path to Kubernetes configuration file. (default \"$HOME/.kube/config\")") | ||
| installCmd.Flags().StringVar(&options.InstanceName, "instance", "", "The instance name. (default to Framework name)") | ||
| installCmd.Flags().StringVar(&options.Namespace, "namespace", "default", "The namespace used for the framework installation. (default \"default\"") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/component kudoctl
/kind cleanup
What this PR does / why we need it:
Prefer explicitly passing parameters instead of global context of variables.
Which issue(s) this PR fixes:
Fixes #290
Special notes for your reviewer:
Does this PR introduce a user-facing change?: