Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up comments #329

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Clean up comments #329

merged 2 commits into from
Jun 13, 2019

Conversation

gkleiman
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Minor code style cleanups to improve readability.

Does this PR introduce a user-facing change?:

NONE

pkg/apis/kudo/v1alpha1/frameworkversion_types.go Outdated Show resolved Hide resolved
pkg/apis/kudo/v1alpha1/frameworkversion_types.go Outdated Show resolved Hide resolved
pkg/apis/kudo/v1alpha1/frameworkversion_types.go Outdated Show resolved Hide resolved
pkg/apis/kudo/v1alpha1/frameworkversion_types.go Outdated Show resolved Hide resolved
pkg/apis/kudo/v1alpha1/frameworkversion_types.go Outdated Show resolved Hide resolved
pkg/controller/instance/instance_controller.go Outdated Show resolved Hide resolved
pkg/controller/planexecution/planexecution_controller.go Outdated Show resolved Hide resolved
pkg/kudoctl/util/repo/repo.go Outdated Show resolved Hide resolved
pkg/util/health/ready.go Outdated Show resolved Hide resolved
Co-Authored-By: Fabian Baier <fabian@mesosphere.io>
@gkleiman
Copy link
Contributor Author

@fabianbaier thank you so much for the help with the cleanup and for your review =). I applied all your suggestions.

@gerred gerred added this to In progress in KUDO via automation Jun 13, 2019
@gerred gerred added this to the 0.3.0 milestone Jun 13, 2019
Copy link
Member

@fabianbaier fabianbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KUDO automation moved this from In progress to Reviewer approved Jun 13, 2019
@gkleiman gkleiman merged commit b9398ae into master Jun 13, 2019
KUDO automation moved this from Reviewer approved to Done Jun 13, 2019
@gkleiman gkleiman deleted the cleanup-comments branch June 13, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
KUDO
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants