Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set integration test tags on instance_controller tests. #387

Merged

Conversation

jbarrick-mesosphere
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This adds the integration test build tag to the instance controller test suite so that they do not run on unit tests runs.

Which issue(s) this PR fixes:

Fixes #338

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jbarrick-mesosphere
Copy link
Member Author

Once this is merged, we can close #338!

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!!

@jbarrick-mesosphere jbarrick-mesosphere merged commit ffe8b16 into kudobuilder:master Jun 24, 2019
@jbarrick-mesosphere jbarrick-mesosphere deleted the build-tags branch June 24, 2019 20:09
@jbarrick-mesosphere jbarrick-mesosphere added this to In progress in KUDO via automation Jun 28, 2019
@jbarrick-mesosphere jbarrick-mesosphere added this to the v0.3.0 milestone Jun 28, 2019
@gerred gerred moved this from In progress to Done in KUDO Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
KUDO
  
Done
Development

Successfully merging this pull request may close these issues.

Add build tags for integration tests
2 participants