Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kudo install help message #457

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Improve kudo install help message #457

merged 4 commits into from
Jun 28, 2019

Conversation

alenkacz
Copy link
Contributor

What type of PR is this?
/component kudoctl

What this PR does / why we need it:
Fixed help for the install command to reflect recent changes.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

pkg/kudoctl/cmd/install.go Show resolved Hide resolved
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with @zen-dog suggestion... lgtm

@@ -69,7 +78,7 @@ func newInstallCmd() *cobra.Command {
installCmd := &cobra.Command{
Use: "install <name>",
Short: "-> Install an official KUDO package.",
Long: `Install a KUDO package from the official GitHub repo.`,
Long: `Install a KUDO package from local filesystem or the official repo.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kensipe kensipe merged commit b41748c into master Jun 28, 2019
@alenkacz alenkacz deleted the av/better-install-help branch October 30, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants