Use KUBECONFIG envvar if set when creating a new client #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
force-pushed
the
honour_kubeconfig_envvar
branch
from
cc8f52f
to
1154289
Compare
yankcrime
changed the title
yankcrime
force-pushed
the
honour_kubeconfig_envvar
branch
from
1154289
to
80d46d7
Compare
yankcrime
requested review from
alenkacz,
fabianbaier and
kensipe
as code owners
oliviabarrick
approved these changes
Jun 30, 2019
kensipe
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/component kudoctl
What this PR does / why we need it:
There's a user expectation that if they've set the
KUBECONFIGenvironment variable in their shell to a valid cluster configuration, this should be picked up and used.Which issue(s) this PR fixes:
Fixes #462
Does this PR introduce a user-facing change?: