Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanup after removing dependencies #476

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Jul 1, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
More additional cleanup for #438

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alenkacz
Copy link
Contributor Author

alenkacz commented Jul 1, 2019

I screwed up and locally started more refactoring in the same file 🙈 now I have troubles with merge conflicts. I am going to merge this one with just one approval so that I can get the next one in 🙏 sorry

@alenkacz alenkacz merged commit 8ce623d into master Jul 1, 2019
@alenkacz alenkacz deleted the av/remove-dependencies branch October 30, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants