Fix matching objects when listing in test harness #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listing objects in the test harness, there was a bug where the a for loop variable was appended to the list of objects to compare causing only the last object (alphabetically) in the namespace to be compared when checking if any objects match the assert. This fixes it by indexing the list instead of taking the address of the loop variable.
alenkacz
reviewed
Jul 3, 2019
| @@ -122,8 +122,8 @@ func (s *Step) CheckResource(expected runtime.Object, namespace string) []error | |||
|
|
|||
| err = s.Client.List(context.TODO(), actual, listOptions...) | |||
|
|
|||
| for _, item := range actual.Items { | |||
| actuals = append(actuals, &item) | |||
| for index := range actual.Items { | |||
There was a problem hiding this comment.
maybe it's too early but I read the description several times and I still feel like these two implementations should do the same thing 🙈
There was a problem hiding this comment.
They aren’t the same, see this post for some background: https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables
Before I took the address of the loop variable which is modified for each iteration of the loop, actuals was a slice of the same pointer over and over.
Now, I take the address of the actual item from the list using the index, so the loop variable isn’t used.
gkleiman
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When listing objects in the test harness, there was a bug where the for loop variable was appended to the list of objects to compare causing only the last object (alphabetically) in the namespace to be compared when checking if any objects match the assert.
This fixes it by indexing the list instead of taking the address of the loop variable.
Found by @gkleiman :)
Does this PR introduce a user-facing change?: