kafka: update cli.md reference to kafka parameters #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
approved these changes
Jul 4, 2019
zmalik
force-pushed
the
zain/update-kafka-docs
branch
from
ebefc71
to
effaf35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small PR to fix documentation around kafka parameters
kudobuilder/operators#40 is merged now
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
The PR goes along with changes in kudobuilder/operators#40 so users don't face issues when following the docs and installing the
kafkaoperatorIn KUDO examples we use
--parameter KAFKA_ZOOKEEPER_URIthat would be now--parameter ZOOKEEPER_URIetcThis PR should be merged once we have merged kudobuilder/operators#40