Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change StringVar to StringVarP for version. Fixes #544 #545

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Change StringVar to StringVarP for version. Fixes #544 #545

merged 2 commits into from
Jul 11, 2019

Conversation

gerred
Copy link
Member

@gerred gerred commented Jul 10, 2019 •
edited
Loading

StringVarP doesn't include short command, but P does, so it was treating "v" as the default value. This fixes #544.

@gerred gerred added this to the v0.4.0 milestone Jul 10, 2019
gkleiman
gkleiman approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@gkleiman gkleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This change made me look at how we handle an empty version, which resulted in this minor PR: #550

alenkacz
alenkacz approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! Thank you :)

@alenkacz alenkacz merged commit 0facf40 into master Jul 11, 2019
kensipe pushed a commit that referenced this pull request Jul 11, 2019
@gerred @kensipe
Change install version StringVar to StringVarP (#545)
3cb7a44
@alenkacz alenkacz deleted the fix-install-flag branch October 30, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkleiman gkleiman gkleiman approved these changes

@alenkacz alenkacz alenkacz approved these changes

@fabianbaier fabianbaier Awaiting requested review from fabianbaier

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Cannot install instance without specifying version
3 participants
@gerred @gkleiman @alenkacz