Fix KUDO step object deletion logic #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PlanExecution controller always returned an error when an object did not exist causing the PlanExecution to never complete. This fixes the conditional logic so that errors for an object being deleted already are suppressed properly.
jbarrick-mesosphere
requested review from
kensipe,
alenkacz,
gerred,
runyontr and
fabianbaier
alenkacz
approved these changes
Jul 11, 2019
alenkacz
reviewed
Jul 11, 2019
| @@ -463,8 +463,7 @@ func (r *ReconcilePlanExecution) Reconcile(request reconcile.Request) (reconcile | |||
| if errors.IsNotFound(err) || err == nil { | |||
| // This is okay | |||
| log.Printf("PlanExecutionController: Object was already deleted or did not exist in step \"%v\"", s.Name) | |||
| } | |||
| if err != nil { | |||
| } else { | |||
fabianbaier
approved these changes
Jul 11, 2019
kensipe
pushed a commit
that referenced
this pull request
Jul 11, 2019
The PlanExecution controller always returned an error when an object did not exist causing the PlanExecution to never complete. This fixes the conditional logic so that errors for an object being deleted already are suppressed properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The PlanExecution controller always returned an error when an object did not exist causing the PlanExecution to never complete.
This fixes the conditional logic so that errors for an object being deleted already are suppressed properly.
Does this PR introduce a user-facing change?: