Replace manifests-dir and manifests-dirs with manifest-dir and ManifestsDirs and ManifestsDir with ManifestDirs. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stsDirs and ManifestsDir with ManifestDirs.
jbarrick-mesosphere
requested review from
alenkacz,
fabianbaier,
gerred,
kensipe and
runyontr
as code owners
alenkacz
approved these changes
Jul 25, 2019
|
😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This fixes the manifestDirs settings to match what we agreed on in #572 (CLI flag
--manifest-dirand the settingManifestDirs)... I just forgot to push my commit before merging 🤦♂️Special notes for your reviewer:
Does this PR introduce a user-facing change?:
^ release note was captured already in #572