-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kudo update integration test #680
Conversation
One thing I notice in these tests is that we're only checking the updates to the Instance specs, but not checking the statuses or any other expected resources. Would it be a good idea to add some other asserts to make sure the upgrade is actually executed as well? Or do we want to consider this a CLI test and have updates covered somewhere else? At any rate, what I think we could add:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, jbarrick-mesosphere The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as with #681 I would like to suggest that we call the tests update-command
instead of kudo-update-command
/kind test |
/lgtm |
What type of PR is this?
/component kudoctl
What this PR does / why we need it:
Integration test for
kudo update
commandWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: