Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kudo update integration test #680

Merged
merged 11 commits into from
Aug 1, 2019
Merged

Kudo update integration test #680

merged 11 commits into from
Aug 1, 2019

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Aug 1, 2019

What type of PR is this?
/component kudoctl

What this PR does / why we need it:
Integration test for kudo update command

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@jbarrick-mesosphere
Copy link
Member

One thing I notice in these tests is that we're only checking the updates to the Instance specs, but not checking the statuses or any other expected resources. Would it be a good idea to add some other asserts to make sure the upgrade is actually executed as well? Or do we want to consider this a CLI test and have updates covered somewhere else?

At any rate, what I think we could add:

  • Assert on plan execution completion in the instance spec.
  • Assert on any of the resources that are created by the operator.

@jbarrick-mesosphere
Copy link
Member

/approve

@kudo-ci
Copy link

kudo-ci commented Aug 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, jbarrick-mesosphere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alenkacz,jbarrick-mesosphere]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as with #681 I would like to suggest that we call the tests update-command instead of kudo-update-command

@jbarrick-mesosphere
Copy link
Member

/kind test

@jbarrick-mesosphere
Copy link
Member

/lgtm

@kudo-ci kudo-ci merged commit 0555202 into master Aug 1, 2019
@kudo-ci kudo-ci deleted the av/update-it branch August 1, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants