Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify feel of install, upgrade and update #688

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Aug 2, 2019

What type of PR is this?
/component kudoctl
/kind cleanup

What this PR does / why we need it:
this unifies the feel of kudo update, upgrade and install.
Until this PR, the situation was looking as follow:

kudo install <package-location> --instance <instance-name> -p a=b
kudo upgrade <package-location> --instance <instance-name> -p a=b
kudo update <instance-name> -p a=b

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@alenkacz alenkacz requested a review from zen-dog August 2, 2019 12:13
@alenkacz alenkacz requested a review from gerred as a code owner August 2, 2019 12:30
@kudo-ci
Copy link

kudo-ci commented Aug 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kensipe
Copy link
Member

kensipe commented Aug 2, 2019

/lgtm

@kudo-ci kudo-ci added the lgtm label Aug 2, 2019
@alenkacz alenkacz merged commit fba47ba into master Aug 2, 2019
@kudo-ci kudo-ci deleted the av/unify-install-upgrade-update branch August 2, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants