-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update min minikube spec to allow zk/kafka #704
Conversation
Welcome @tbaums! It looks like this is your first PR to kudobuilder/kudo 🎉 |
Hi @tbaums. Thanks for your PR. I'm waiting for a kudobuilder member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kafka default requirements are here: https://github.com/kudobuilder/operators/blob/master/repository/kafka/operator/params.yaml#L16 We have three replicas and set a memory request of 2048mb. So that's six gigabytes without accounting for zookeeper and any other running services. A base 6 gigabytes of RAM makes a base kafka cluster expensive to run - either in dev or in production - and represents a higher barrier of entry for new contributors. Additionally, we'll have to account for this in CI and it could limit the number of tests we can run at once. Maybe instead of recommending bigger clusters, we could re-evaluate our limit? Do we know how it was chosen? cc @zmalik |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbarrick-mesosphere, tbaums The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justinbarrick I think those defaults are good defaults for production use, just not necessary for running locally in minikube 🤔 should we just update all examples to install kafka locally with those memory requirements overriden? |
@justinbarrick Kafka defaults are already in the lower part of the spectrum of production-ready defaults. said that as @alenkacz says we can start brokers with as less 512mb of memory by overriding parameters in our tests or local dev installations |
/lgtm Sounds good to me. |
/kind documentation |
/ok-to-test |
Based on simplistic testing, here, minimum minikube requirements to deploy zk and kafka is 4cpu and 10gig of memory.