Fix flake in CreateOrUpdate #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm 🤦♂️ I don't know why I thought this would be more complicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What this PR does / why we need it:
This fixes flake in
TestCreateOrUpdatehttps://circleci.com/gh/kudobuilder/kudo/4560?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-linkAs we're using controller-runtime client that has cache built in it can happen, that
Getreturns no instance but we can no longer create that entity because it exists. I think we should always retry such cases as at one point the cache gets populated and we will hit the update branch and everything will end as success :)Which issue(s) this PR fixes:
Fixes #639
Does this PR introduce a user-facing change?: