Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some wording around the update subcommand #727

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

yankcrime
Copy link
Member

@yankcrime yankcrime commented Aug 19, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Fixes the the example in the docs for the kubectl kudo update command as this is currently incorrect (you need to prefix the instance name with --instance).

I've also tried to fix up some of the wording and naming used inline in the subcommand itself as well as in the documentation.

Does this PR introduce a user-facing change?:

NONE

The example in the docs for the `kubectl kudo upgrade` command is
incorrect (you need to prefix the instance name with `--instance`).

Fix up some of the wording and naming used inline in the subcommand
itself as well as in the documentation.
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

@kudo-ci
Copy link

kudo-ci commented Aug 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kensipe, yankcrime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kensipe
Copy link
Member

kensipe commented Aug 19, 2019

/lgtm

@kudo-ci kudo-ci added the lgtm label Aug 19, 2019
@kudo-ci kudo-ci merged commit 388a9f9 into kudobuilder:master Aug 19, 2019
@yankcrime yankcrime deleted the instance_upgrade_fixes branch August 19, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants