switching maintainer back to 0.5.0 release and adding marshaling tests #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensipe
requested review from
alenkacz,
fabianbaier and
gerred
as code owners
gerred
approved these changes
Sep 3, 2019
|
added all elements to the golden index file and provided a parsing test. This should catch future breakage. |
|
@kensipe is it worth having some Makefile task to regenerate that golden file? maybe not needed in this case? |
alenkacz
approved these changes
Sep 4, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, gerred, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #748
Special notes for your reviewer:
Does this PR introduce a user-facing change?: